hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1076) HFDS CLI error tests fail with Avro RPC
Date Tue, 06 Apr 2010 01:24:28 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853678#action_12853678
] 

Suresh Srinivas commented on HDFS-1076:
---------------------------------------

RPC server sends exception class name and printed stack trace in response. At the client:
# if the exception is unwrapped, with the message set to the first line of printed stack trace
from response. The message is "<Server exception class name>: <server exception message>"
#* In this case including the exception name in the message is redundant. While unwrapping,
I propose removing the "<exception class name>: " from the message. Other than HDFSCli
test I cannot think of a reason why an application depends on the error string to include
exception name, especially given that the exception type that is thrown has that information
already.
# if the exception is not unwrapped, RemoteException is thrown as it is, with printed stack
trace as the message.
#* We should retain this. The exception name here along with the stack trace (albeit the server
side) could be useful for debugging.

If we agree, I will make this change in trunk. We could retain equivalent behavior for Avro.





> HFDS CLI error tests fail with Avro RPC
> ---------------------------------------
>
>                 Key: HDFS-1076
>                 URL: https://issues.apache.org/jira/browse/HDFS-1076
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>             Fix For: 0.22.0
>
>         Attachments: HDFS-1076.patch
>
>
> Some HDFS command-line tests (TestHDFSCLI) fail when using AvroRpcEngine because the
error string does not match.  Calling getMessage() on a remote exception thrown by WritableRpcEngine
produces a string that contains the exception name followed by its getMessage(), while exceptions
thrown by AvroRpcEngine contain just the getMessage() string of the original exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message