hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Doug Cutting (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1077) namenode RPC protocol method names are overloaded
Date Fri, 02 Apr 2010 23:17:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12852991#action_12852991
] 

Doug Cutting commented on HDFS-1077:
------------------------------------

These fall into two categories:
 - versionRequest and reportBadBlocks, otherwise identical methods duplicated in multiple
protocols.  These could perhaps be moved to a shared common interfaces.  Alternately we could
try to get Avro to ignore multiple identical methods (same name and parameters).  The simplest
change would be just to rename one of them, so that each protocol had a unique method name
and they did not collide when combined in the namenode.
 - delete, rename and errorReport are overloaded with different parameter lists.  These are
best renamed, as they're different messages with different semantics.

Renaming any of these would not be incompatible, since RPC methods are not currently public.


> namenode RPC protocol method names are overloaded
> -------------------------------------------------
>
>                 Key: HDFS-1077
>                 URL: https://issues.apache.org/jira/browse/HDFS-1077
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>
> Avro RPC does not permit two different messages with the same name.  Several namenode
RPC protocol method names are overloaded.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message