hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tom White (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-776) Fix exception handling in Balancer
Date Tue, 27 Apr 2010 04:15:36 GMT

    [ https://issues.apache.org/jira/browse/HDFS-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12861227#action_12861227
] 

Tom White commented on HDFS-776:
--------------------------------

This shouldn't necessarily be considered a blocker for 0.21 - it could be fixed in a point
release for example.

> Fix exception handling in Balancer
> ----------------------------------
>
>                 Key: HDFS-776
>                 URL: https://issues.apache.org/jira/browse/HDFS-776
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: balancer
>            Reporter: Owen O'Malley
>            Priority: Blocker
>             Fix For: 0.21.0
>
>
> The Balancer's AccessKeyUpdater handles exceptions badly. In particular:
> 1. Catching Exception too low. The wrapper around setKeys should only catch IOException.
> 2. InterruptedException is ignored. It should be caught at the top level and exit run.
> 3. Throwable is not caught. It should be caught at the top level and kill the Balancer
server process.
> {code}
>   class AccessKeyUpdater implements Runnable {
>     public void run() {
>       while (shouldRun) {
>         try {
>           accessTokenHandler.setKeys(namenode.getAccessKeys());
>         } catch (Exception e) {
>           LOG.error(StringUtils.stringifyException(e));
>         }
>         try {
>           Thread.sleep(keyUpdaterInterval);
>         } catch (InterruptedException ie) {
>         }
>       }
>     }
>   }
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message