hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HDFS-955) FSImage.saveFSImage can lose edits
Date Fri, 26 Mar 2010 02:35:27 GMT

     [ https://issues.apache.org/jira/browse/HDFS-955?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Konstantin Shvachko updated HDFS-955:
-------------------------------------

    Attachment: saveNamespace.txt

This patch fixes the problem. The algorithm is as follows:
# if current exists, then rename current to lastcheckpoint.tmp
# create new current directory, and save new image into it
# remove previous.checkpoint if exists
# rename lastcheckpoint.tmp to previous.checkpoint

I added the new recovery cases to TestDFSStorageStateRecovery.
I modified Todd's test to reflect the new code. I renamed saveFSImage() to saveNamespace(),
because it saves both fsimafe and edits.

> FSImage.saveFSImage can lose edits
> ----------------------------------
>
>                 Key: HDFS-955
>                 URL: https://issues.apache.org/jira/browse/HDFS-955
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.20.1, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Blocker
>         Attachments: FSStateTransition7.htm, hdfs-955-moretests.txt, hdfs-955-unittest.txt,
PurgeEditsBeforeImageSave.patch, saveNamespace.txt
>
>
> This is a continuation of a discussion from HDFS-909. The FSImage.saveFSImage function
(implementing dfsadmin -saveNamespace) can corrupt the NN storage such that all current edits
are lost.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message