hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-1001) DataXceiver and BlockReader disagree on when to send/recv CHECKSUM_OK
Date Thu, 18 Mar 2010 18:30:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-1001?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12847052#action_12847052
] 

Todd Lipcon commented on HDFS-1001:
-----------------------------------

The body of patch looks good to me. But could we merge TestClientBlockVerification and the
new TestDataXceiver? I recall you made the new test so you could be in the server.datanode
package, but could the cases of TestClientBlockVerification move in here too? If not, maybe
we can at least share a bit of the test code (most of the code except for the test case itself
is duplicated)

> DataXceiver and BlockReader disagree on when to send/recv CHECKSUM_OK
> ---------------------------------------------------------------------
>
>                 Key: HDFS-1001
>                 URL: https://issues.apache.org/jira/browse/HDFS-1001
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.22.0
>            Reporter: bc Wong
>            Assignee: bc Wong
>         Attachments: HDFS-1001-rebased.patch, HDFS-1001.patch, HDFS-1001.patch.1
>
>
> Running the TestPread with additional debug statements reveals that the BlockReader sends
CHECKSUM_OK when the DataXceiver doesn't expect it. Currently it doesn't matter since DataXceiver
closes the connection after each op, and CHECKSUM_OK is the last thing on the wire. But if
we want to cache connections, they need to agree on the exchange of CHECKSUM_OK.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message