hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-894) DatanodeID.ipcPort is not updated when existing node re-registers
Date Wed, 03 Feb 2010 01:49:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-894?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12828887#action_12828887
] 

Hadoop QA commented on HDFS-894:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12434614/hdfs-894.txt
  against trunk revision 905760.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 2 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed core unit tests.

    -1 contrib tests.  The patch failed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/111/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/111/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/111/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/111/console

This message is automatically generated.

> DatanodeID.ipcPort is not updated when existing node re-registers
> -----------------------------------------------------------------
>
>                 Key: HDFS-894
>                 URL: https://issues.apache.org/jira/browse/HDFS-894
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.20.1, 0.21.0, 0.22.0
>            Reporter: Todd Lipcon
>            Priority: Blocker
>         Attachments: hdfs-894.txt
>
>
> In FSNamesystem.registerDatanode, it checks if a registering node is a reregistration
of an old one based on storage ID. If so, it simply updates the old one with the new registration
info. However, the new ipcPort is lost when this happens.
> I produced manually this by setting up a DN with IPC port set to 0 (so it picks an ephemeral
port) and then restarting the DN. At this point, the NN's view of the ipcPort is stale, and
clients will not be able to achieve pipeline recovery.
> This should be easy to fix and unit test, but not sure when I'll get to it, so anyone
else should feel free to grab it if they get to it first.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message