hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-984) Delegation Tokens should be persisted in Namenode
Date Mon, 22 Feb 2010 23:52:28 GMT

    [ https://issues.apache.org/jira/browse/HDFS-984?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12836998#action_12836998

Konstantin Shvachko commented on HDFS-984:

Including comments for both issue this one and HADOOP-6573.
# Interchanging names logGetDelegationToken() and logAddDelegationToken() are confusing -
should be consistent either all Get or all Add. Should OP_GET_DELEGATION_TOKEN be OP_ADD_DELEGATION_TOKEN?
# Reuse the instance of DelegationTokenIdentifier in loadFSEdits()
# loadFSEdits() should log new token ops in debug mode.
# I think we should throw an exception if the same token is added (not renewed) twice.
# AbstractDelegationTokenSecretManager uses 2 locks (this and currentTokens) - probably an
attempt to do a read/write lock. You don't use them consistently.
 currentTokens.get() returns a reference to the value, not a copy. So when you access the
value fields outside the lock they may be changing by other threads. It would be better to
have just one lock (this).
# No need to make isInSafeMode() public.
# Import warnings in FSNamesystem, DelegationTokenSecretManager
# @Override // <which class it overrides>
# public methods and classes must have JavaDoc.

> Delegation Tokens should be persisted in Namenode
> -------------------------------------------------
>                 Key: HDFS-984
>                 URL: https://issues.apache.org/jira/browse/HDFS-984
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>         Attachments: HDFS-984.10.patch, HDFS-984.7.patch
> The Delegation tokens should be persisted in the FsImage and EditLogs so that they are
valid to be used after namenode shutdown and restart.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message