Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 75294 invoked from network); 26 Jan 2010 05:31:08 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 26 Jan 2010 05:31:08 -0000 Received: (qmail 668 invoked by uid 500); 26 Jan 2010 05:31:08 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 597 invoked by uid 500); 26 Jan 2010 05:31:08 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 586 invoked by uid 99); 26 Jan 2010 05:31:08 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2010 05:31:08 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 26 Jan 2010 05:30:57 +0000 Received: from brutus.apache.org (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 518CF234C4CF for ; Mon, 25 Jan 2010 21:30:36 -0800 (PST) Message-ID: <937608313.31081264483836333.JavaMail.jira@brutus.apache.org> Date: Tue, 26 Jan 2010 05:30:36 +0000 (UTC) From: "Hudson (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-822) Appends to already-finalized blocks can rename across volumes In-Reply-To: <51120128.1260406218109.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12804902#action_12804902 ] Hudson commented on HDFS-822: ----------------------------- Integrated in Hdfs-Patch-h5.grid.sp2.yahoo.net #205 (See [http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/205/]) > Appends to already-finalized blocks can rename across volumes > ------------------------------------------------------------- > > Key: HDFS-822 > URL: https://issues.apache.org/jira/browse/HDFS-822 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node > Affects Versions: 0.21.0, 0.22.0 > Reporter: Todd Lipcon > Assignee: Hairong Kuang > Priority: Blocker > Fix For: 0.21.0, 0.22.0 > > Attachments: HDFS-822.patch, HDFS-822.patch, HDFS-822.patch > > > This is a performance thing. As I understand the code in FSDataset.append, if the block is already finalized, it needs to move it into the RBW directory so it can go back into a "being written" state. This is done using volumes.getNextVolume without preference to the volume that the block currently exists on. It seems to me that this could cause a lot of slow cross-volume copies on applications that periodically append/close/append/close a file. Instead, getNextVolume could provide an alternate form that gives preference to a particular volume, so the rename stays on the same disk. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.