[ https://issues.apache.org/jira/browse/HDFS-881?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Todd Lipcon updated HDFS-881:
-----------------------------
Attachment: hdfs-881.txt
This implements the proposed refactor.
Couple notes:
- I had to implement read/write fields both for OutputStream and for ByteBuffer in/out. It's
a bit ugly, but I wasn't able to find a way of avoiding one or the other without adding extra
double buffering or writing some kind of ByteBuffer<->DataOutput translation class in
Common util. If we think this is necessary, let's do it in another JIRA.
- I changed the meaning of PKT_HEADER_LEN when moving it into the new class. It used to be
that nearly every instance of its use also added SIZE_OF_INTEGER, so I just incorporated that
into the constant to make the code simpler everywhere else.
> Refactor DataNode Packet header into DataTransferProtocol
> ---------------------------------------------------------
>
> Key: HDFS-881
> URL: https://issues.apache.org/jira/browse/HDFS-881
> Project: Hadoop HDFS
> Issue Type: Improvement
> Affects Versions: 0.22.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hdfs-881.txt
>
>
> The Packet Header format is used ad-hoc in various places. This JIRA is to refactor it
into a class inside DataTransferProtocol (like was done with PipelineAck)
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
|