hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-928) Ability to provide custom DatanodeProtocol implementation
Date Thu, 28 Jan 2010 00:56:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-928?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12805726#action_12805726
] 

Konstantin Boudnik commented on HDFS-928:
-----------------------------------------

I see this testing issue the other way around: there are two classes implementing this interface
i.e. {{NameNode}} and {{BackupNode}}. Both of them could be mocked using Mockito framework
(which is included into HDFS since HDFS-669) and then tested in any desirable way.

Don't get me wrong: I'm rejecting the idea outright but rather trying to realize the merit
of the proposal.

> Ability to provide custom DatanodeProtocol implementation
> ---------------------------------------------------------
>
>                 Key: HDFS-928
>                 URL: https://issues.apache.org/jira/browse/HDFS-928
>             Project: Hadoop HDFS
>          Issue Type: Wish
>          Components: data-node
>            Reporter: Zlatin Balevsky
>            Priority: Trivial
>
> This should make testing easier as well as allow users to provide their own RPC/namenode
implementations.  It's pretty straightforward:
> 1. add 
> interface DatanodeProtocolProvider {
>   DatanodeProtocol getNameNode(Configuration conf);
> }
> 2. add a config setting like "dfs.datanode.protocol.impl"
> 3. create a default implementation and copy/paste the RPC initialization code there

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message