hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-844) Log the filename when file locking fails
Date Fri, 18 Dec 2009 17:42:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12792543#action_12792543
] 

Todd Lipcon commented on HDFS-844:
----------------------------------

Looks fine, but why you're at it, why not change to:
LOG.error("Cannot create lock on " + lockF, e);

(error level instead of info, since it really is problematic, and use the two-arg logger form
instead of stringifying the exception)

> Log the filename when file locking fails
> ----------------------------------------
>
>                 Key: HDFS-844
>                 URL: https://issues.apache.org/jira/browse/HDFS-844
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Tom White
>            Assignee: Tom White
>         Attachments: HDFS-844.patch
>
>
> When the storage lock cannot be acquired in StorageDirectory.tryLock() the the error
message does not show the storage volume that was at fault. The log message is very generic:
> {code}
> common.Storage: java.io.IOException: Input/output error
> {code}

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message