hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-192) TestBackupNode sometimes fails
Date Fri, 04 Dec 2009 19:56:20 GMT

    [ https://issues.apache.org/jira/browse/HDFS-192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12786115#action_12786115
] 

Suresh Srinivas commented on HDFS-192:
--------------------------------------

Thanks for detailed and very good explanation of the fix.

Here are the comments:
# BackupNode.java and NameNode.java stop methods should be synchronized. We should record
the fact that shutdown happened on BackupNode (similar to NameNode.stop()). This will ensure
that even if shutdown is called twice (BackupNameNode triggering CheckPointer shutdown, which
in turn calls BackupNameNode shutdown) does not result in cleanup attempt twice.
# BackupNode.stop() should set checkPointerManager to null after interrupting it?
# BackupNode.stop() comments could be clear on why checkpointManager.shouldRun is set to false,
and only later it is interrupted. Otherwise, some one would merge the two.

Otherwise patch looks good.

> TestBackupNode sometimes fails
> ------------------------------
>
>                 Key: HDFS-192
>                 URL: https://issues.apache.org/jira/browse/HDFS-192
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Konstantin Shvachko
>             Fix For: 0.21.0
>
>         Attachments: HADOOP-5573.patch, NN-EditsBug.patch, TestBNFailure.log
>
>
> TestBackupNode may fail with different reasons:
> - Unable to open edit log file .\build\test\data\dfs\name-backup1\current\edits (FSEditLog.java:open(371))
> - NullPointerException at org.apache.hadoop.hdfs.server.namenode.EditLogBackupOutputStream.flushAndSync(EditLogBackupOutputStream.java:163)
> - Fatal Error : All storage directories are inaccessible.
> Will provide more information in the comments.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message