hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-775) FSDataset calls getCapacity() twice -bug?
Date Wed, 09 Dec 2009 22:21:18 GMT

    [ https://issues.apache.org/jira/browse/HDFS-775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12788354#action_12788354

Todd Lipcon commented on HDFS-775:

+1. Patch looks good to me.

> FSDataset calls getCapacity() twice -bug?
> -----------------------------------------
>                 Key: HDFS-775
>                 URL: https://issues.apache.org/jira/browse/HDFS-775
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.22.0
>            Reporter: Steve Loughran
>            Priority: Minor
>             Fix For: 0.22.0
>         Attachments: HDFS-775-1.patch, HDFS-775-2.patch
> I'm not sure this is a bug or "as intended", but I thought I'd mention it.
> FSDataset.getCapacity() calls DF.getCapacity() twice, when evaluating its capacity. Although
there is caching to stop the shell being exec'd twice in a row, there is a risk that the first
call doesn't run the shell, and the second does -so the value changes during the method. 
> If that is not intended, it is better to cache the first value for the whole method

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message