Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 53769 invoked from network); 12 Nov 2009 23:53:10 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 12 Nov 2009 23:53:10 -0000 Received: (qmail 96664 invoked by uid 500); 12 Nov 2009 23:53:10 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 96600 invoked by uid 500); 12 Nov 2009 23:53:10 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 96589 invoked by uid 99); 12 Nov 2009 23:53:10 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2009 23:53:10 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Nov 2009 23:53:00 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 93BAC234C1EF for ; Thu, 12 Nov 2009 15:52:39 -0800 (PST) Message-ID: <1989120927.1258069959590.JavaMail.jira@brutus> Date: Thu, 12 Nov 2009 23:52:39 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-669) Add unit tests In-Reply-To: <1592012842.1254422543665.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12777284#action_12777284 ] Hadoop QA commented on HDFS-669: -------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12424759/HDFS-669.sh against trunk revision 835534. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 2 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/74/console This message is automatically generated. > Add unit tests > --------------- > > Key: HDFS-669 > URL: https://issues.apache.org/jira/browse/HDFS-669 > Project: Hadoop HDFS > Issue Type: Test > Components: test > Affects Versions: 0.21.0, 0.22.0 > Reporter: Eli Collins > Assignee: Konstantin Boudnik > Attachments: HDFS-669.patch, HDFS-669.patch, HDFS-669.patch, HDFS-669.patch, HDFS-669.patch, HDFS-669.patch, HDFS-669.patch, HDFS-669.sh, HDFS669.patch > > > Most HDFS tests are functional tests that test a feature end to end by running a mini cluster. We should add more tests like TestReplication that attempt to stress individual classes in isolation, ie by stubbing out dependencies without running a mini cluster. This allows for more fine-grain testing and making tests run much more quickly because they avoid the cost of cluster setup and teardown. If it makes sense to use another framework besides junit we should standardize with MAPREDUCE-1050. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.