Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 18656 invoked from network); 9 Nov 2009 20:46:56 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 9 Nov 2009 20:46:56 -0000 Received: (qmail 69602 invoked by uid 500); 9 Nov 2009 20:46:56 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 69571 invoked by uid 500); 9 Nov 2009 20:46:56 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 69521 invoked by uid 99); 9 Nov 2009 20:46:56 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Nov 2009 20:46:55 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 09 Nov 2009 20:46:52 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 95DE4234C4A9 for ; Mon, 9 Nov 2009 12:46:32 -0800 (PST) Message-ID: <1729925021.1257799592612.JavaMail.jira@brutus> Date: Mon, 9 Nov 2009 20:46:32 +0000 (UTC) From: "Konstantin Boudnik (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-669) Add unit tests In-Reply-To: <1592012842.1254422543665.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12775125#action_12775125 ] Konstantin Boudnik commented on HDFS-669: ----------------------------------------- I'm sure you've noticed that already, but the test cases are failing with the following diagnostics: {noformat} ... 2009-11-09 12:33:37,906 INFO metrics.FSNamesystemMetrics (FSNamesystemMetrics.java:(78)) - Initializing FSNamesystemMetrics using context object:org.apache.hadoop.metrics. spi.NullContext 2009-11-09 12:33:37,915 INFO namenode.FSNamesystem (FSNamesystem.java:registerMBean(3991)) - Registered FSNamesystemStatusMBean 2009-11-09 12:33:37,973 WARN conf.Configuration (Configuration.java:handleDeprecation(326)) - fs.checkpoint.dir is deprecated. Instead, use dfs.namenode.checkpoint.dir 2009-11-09 12:33:37,975 WARN namenode.FSNamesystem (FSNamesystem.java:getStorageDirs(350)) - Scheme is undefined for /tmp/hadoop-cos/dfs/name 2009-11-09 12:33:37,975 WARN namenode.FSNamesystem (FSNamesystem.java:getStorageDirs(351)) - Please check your file system configuration in hdfs-site.xml 2009-11-09 12:33:37,976 WARN namenode.FSNamesystem (FSNamesystem.java:getStorageDirs(350)) - Scheme is undefined for /tmp/hadoop-cos/dfs/name 2009-11-09 12:33:37,976 WARN namenode.FSNamesystem (FSNamesystem.java:getStorageDirs(351)) - Please check your file system configuration in hdfs-site.xml 2009-11-09 12:33:37,981 INFO common.Storage (Storage.java:analyzeStorage(356)) - Storage directory /private/tmp/hadoop-cos/dfs/name does not exist. 2009-11-09 12:33:37,985 ERROR namenode.FSNamesystem (FSNamesystem.java:(244)) - FSNamesystem initialization failed. org.apache.hadoop.hdfs.server.common.InconsistentFSStateException: Directory /private/tmp/hadoop-cos/dfs/name is in an inconsistent state: storage directory does not exist or is not accessible. at org.apache.hadoop.hdfs.server.namenode.FSImage.recoverTransitionRead(FSImage.java:401) at org.apache.hadoop.hdfs.server.namenode.FSDirectory.loadFSImage(FSDirectory.java:112) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.initialize(FSNamesystem.java:261) at org.apache.hadoop.hdfs.server.namenode.FSNamesystem.(FSNamesystem.java:242) at org.apache.hadoop.hdfs.server.namenode.TestFSNamesystem.getNamesystem(TestFSNamesystem.java:49) at org.apache.hadoop.hdfs.server.namenode.TestFSNamesystem.testRenameInSafemode(TestFSNamesystem.java:54) ... {noformat} > Add unit tests > --------------- > > Key: HDFS-669 > URL: https://issues.apache.org/jira/browse/HDFS-669 > Project: Hadoop HDFS > Issue Type: Test > Components: test > Reporter: Eli Collins > Assignee: Eli Collins > Attachments: HDFS669.patch > > > Most HDFS tests are functional tests that test a feature end to end by running a mini cluster. We should add more tests like TestReplication that attempt to stress individual classes in isolation, ie by stubbing out dependencies without running a mini cluster. This allows for more fine-grain testing and making tests run much more quickly because they avoid the cost of cluster setup and teardown. If it makes sense to use another framework besides junit we should standardize with MAPREDUCE-1050. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.