hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-669) Add unit tests
Date Wed, 11 Nov 2009 21:50:48 GMT

    [ https://issues.apache.org/jira/browse/HDFS-669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12776681#action_12776681
] 

Jakob Homan commented on HDFS-669:
----------------------------------

* I ran with the patch and using -Dtestcase=TestFSNamesystem and the test was executed twice.
 
* The testDirNQuota() test concerns me as it is not readily apparent what role the spied-on
instance is playing and thus may not be a good example of how to use Mockito.  At the very
least, an explanation of how the spy is playing a role would be good.  This is comparison
to the other test, where it is clear that the isInSameMode() call is intercepted and re-defined.

> Add unit tests 
> ---------------
>
>                 Key: HDFS-669
>                 URL: https://issues.apache.org/jira/browse/HDFS-669
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>            Reporter: Eli Collins
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-669.patch, HDFS-669.patch, HDFS-669.patch, HDFS-669.patch,
HDFS669.patch
>
>
> Most HDFS tests are functional tests that test a feature end to end by running a mini
cluster. We should add more tests like TestReplication that attempt to stress individual classes
in isolation, ie by stubbing out dependencies without running a mini cluster. This allows
for more fine-grain testing and making tests run much more quickly because they avoid the
cost of cluster setup and teardown. If it makes sense to use another framework besides junit
we should standardize with MAPREDUCE-1050. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message