Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 66587 invoked from network); 23 Oct 2009 19:12:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 23 Oct 2009 19:12:23 -0000 Received: (qmail 20993 invoked by uid 500); 23 Oct 2009 19:12:23 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 20959 invoked by uid 500); 23 Oct 2009 19:12:23 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 20941 invoked by uid 99); 23 Oct 2009 19:12:23 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Oct 2009 19:12:23 +0000 X-ASF-Spam-Status: No, hits=-10.5 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_HI X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Oct 2009 19:12:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id A136C234C1F1 for ; Fri, 23 Oct 2009 12:11:59 -0700 (PDT) Message-ID: <1728990126.1256325119658.JavaMail.jira@brutus> Date: Fri, 23 Oct 2009 19:11:59 +0000 (UTC) From: "Hairong Kuang (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-222) Support for concatenating of files into a single file MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12769372#action_12769372 ] Hairong Kuang commented on HDFS-222: ------------------------------------ Borris, sorry that more comments are here. Hope that this will be the last iteration: # Exam all loggings at the info level to see if you can either remove them or change them to be debug level # Remove the change to BlockManager.java since the code is already commented. # FSNamesystem.java: #* no need to verify quota since target and sources are in the same directory #* should use getINodeFile to get inode of target & sources #* no need to check if srcInode is root #* minor: cacatInternal better to be a synchronized method in FSDirectory # FSDirectory.java #* No need to track & update disk space consumed in upprotectedConcat. #* in deleteFileWithoutComment, no need to update modification time for the parent for every source & update disk space consumed. #* you might be able to remove deleteFileWithoutCommit to take advantage of target & sources are under one parent. #* minor: optimize the number of copies when concatenating blocks. # FSEditLog.java: check version # for handling OP_CONCAT_DELETE in loadEditLogs. > Support for concatenating of files into a single file > ----------------------------------------------------- > > Key: HDFS-222 > URL: https://issues.apache.org/jira/browse/HDFS-222 > Project: Hadoop HDFS > Issue Type: New Feature > Reporter: Venkatesh S > Assignee: Boris Shkolnik > Attachments: HDFS-222-1.patch, HDFS-222-2.patch, HDFS-222-3.patch, HDFS-222-4.patch, HDFS-222-5.patch, HDFS-222-6.patch, HDFS-222-7.patch, HDFS-222-8.patch, HDFS-222-9.patch, HDFS-222.patch > > > An API to concatenate files of same size and replication factor on HDFS into a single larger file. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.