Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 78042 invoked from network); 7 Oct 2009 03:40:55 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 7 Oct 2009 03:40:55 -0000 Received: (qmail 25983 invoked by uid 500); 7 Oct 2009 03:40:55 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 25919 invoked by uid 500); 7 Oct 2009 03:40:55 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 25908 invoked by uid 99); 7 Oct 2009 03:40:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Oct 2009 03:40:55 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Oct 2009 03:40:52 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 49E1E234C03A for ; Tue, 6 Oct 2009 20:40:31 -0700 (PDT) Message-ID: <1482182764.1254886831291.JavaMail.jira@brutus> Date: Tue, 6 Oct 2009 20:40:31 -0700 (PDT) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-555) A few improvements to DataNodeCluster - HADOOP-5556 In-Reply-To: <1679056875.1250791994800.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-555?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12762853#action_12762853 ] Hadoop QA commented on HDFS-555: -------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12417205/HDFS-555-v1.patch against trunk revision 822153. +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 12 new or modified tests. -1 patch. The patch command could not apply the patch. Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/17/console This message is automatically generated. > A few improvements to DataNodeCluster - HADOOP-5556 > ---------------------------------------------------- > > Key: HDFS-555 > URL: https://issues.apache.org/jira/browse/HDFS-555 > Project: Hadoop HDFS > Issue Type: Improvement > Components: test > Affects Versions: 0.21.0 > Reporter: Ravi Phulari > Assignee: Hairong Kuang > Priority: Blocker > Fix For: 0.21.0 > > Attachments: HDFS-555-v1.patch, HDFS-555.patch > > > Opening jira to address HDFS code changes made in HADOOP-5556. > DataNodeCluster is a great tool to simulate a large scale DFS cluster using a small set of machines. A few suggestions to improve this tool: > 1. DataNodeCluster uses MiniDFSCluster#startDataNode to start multiple instances of DataNode on one machine. MiniDFSCluster sets DataNode's address to be 127.0.0.1. We should allow to set its address to 0.0.0.0 so DataNodes in different machines could communicate. > 2. Currently the size of the blocks injected to DataNode and created in CreatedEditsLog is hardcoded as 10. It would be more convenient if this could be configurable. Also we need to make sure that both use the same block size. > 3. If the replication factor of blocks is larger than 1, currently a DataNode in DataNodeCluster will be injected blocks multiple times and therefore it sends block reports to NameNode multiple times. Initial block reports contain only a portion of its blocks and therefore may cause unnecessary block replications. It would be cleaner if only one block report with all its blocks is sent. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.