Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 10607 invoked from network); 13 Oct 2009 23:59:57 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 13 Oct 2009 23:59:57 -0000 Received: (qmail 18674 invoked by uid 500); 13 Oct 2009 23:59:55 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 18637 invoked by uid 500); 13 Oct 2009 23:59:55 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 18571 invoked by uid 99); 13 Oct 2009 23:59:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2009 23:59:55 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Oct 2009 23:59:52 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 603BE234C052 for ; Tue, 13 Oct 2009 16:59:31 -0700 (PDT) Message-ID: <130263009.1255478371393.JavaMail.jira@brutus> Date: Tue, 13 Oct 2009 16:59:31 -0700 (PDT) From: "Hairong Kuang (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-29) In Datanode, update block may fail due to length inconsistency MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765317#action_12765317 ] Hairong Kuang commented on HDFS-29: ----------------------------------- +1. The patch looks good. > In Datanode, update block may fail due to length inconsistency > -------------------------------------------------------------- > > Key: HDFS-29 > URL: https://issues.apache.org/jira/browse/HDFS-29 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Tsz Wo (Nicholas), SZE > Fix For: 0.21.0, 0.22.0 > > Attachments: h29_20091012.patch, h29_20091012b.patch, h29_20091012c.patch > > > When a primary datanode tries to recover a block. It calls getBlockMetaDataInfo(..) to obtains information like block length from each datanode. Then, it calls updateBlock(..). > The block length returned in getBlockMetaDataInfo(..) may be obtained from a unclosed local block file F. However, in updateBlock(..), it first closes F (if F is open) and then gets the length. These two lengths may be different. In such case, updateBlock(..) throws an exception. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.