hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-29) In Datanode, update block may fail due to length inconsistency
Date Tue, 13 Oct 2009 21:27:31 GMT

    [ https://issues.apache.org/jira/browse/HDFS-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765240#action_12765240
] 

Tsz Wo (Nicholas), SZE commented on HDFS-29:
--------------------------------------------

{noformat}
     [exec] +1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
{noformat}
Also passed all unit tests locally.

> In Datanode, update block may fail due to length inconsistency
> --------------------------------------------------------------
>
>                 Key: HDFS-29
>                 URL: https://issues.apache.org/jira/browse/HDFS-29
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.21.0, 0.22.0
>
>         Attachments: h29_20091012.patch, h29_20091012b.patch, h29_20091012c.patch
>
>
> When a primary datanode tries to recover a block.  It calls getBlockMetaDataInfo(..)
to obtains information like block length from each datanode.  Then, it calls updateBlock(..).
> The block length returned in getBlockMetaDataInfo(..) may be obtained from a unclosed
local block file F.   However, in updateBlock(..), it first closes F (if F is open) and then
gets the length.  These two lengths may be different.  In such case, updateBlock(..) throws
an exception.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message