hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-654) HDFS needs to support new rename introduced for FileContext
Date Sat, 03 Oct 2009 00:50:23 GMT

    [ https://issues.apache.org/jira/browse/HDFS-654?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12761789#action_12761789
] 

Konstantin Shvachko commented on HDFS-654:
------------------------------------------

# Parameter type {{Options.Rename}} would look better in {{rename()}} methods.
# Increment {{ClientProtocol}} version.
# import warning in FSDirectory.
# Decrement {{LAYOUT_VERSION}} as you introduce new journal record.
# I think that the whole stack of old {{rename()}} methods should be deprecated starting from
{{DistributedFileSystem.rename(src, dst)}} down to {{FSDirectory.unprotectedRenameTo()}}.
Because otherwise people writing tests or pure HDFS applications will not know which rename
to use, and may by mistake use the one with the old semantics, which is not desirable. It
will also clarify why you did not reuse code for 2 renames, but rather built a whole new branch
of methods for the new semantics.
# It is better to put comments related to deprecation in JavaDoc under {{/** @deprecated **/}}
section.
# {{FSEditLog.OP_RENAME}} should be used for the new semantics. The old rename operation should
be called {{FSEditLog.OP_RENAME_OLD}} so that we could remove it later.
# You should probably verify that old layout images do not contain new rename op.

> HDFS needs to support new rename introduced for FileContext
> -----------------------------------------------------------
>
>                 Key: HDFS-654
>                 URL: https://issues.apache.org/jira/browse/HDFS-654
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 0.21.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: hdfs-654.1.patch, hdfs-654.2.patch, HDFS-654.patch
>
>
> New rename functionality with different semantics to overwrite the existing destination
was introduced for use in FileContext. Currently the default implementation in FileSystem
is not atomic. This change implements atomic rename operation for use by FileContext.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message