hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hairong Kuang (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-673) BlockReceiver#PacketResponder should not remove a packet from the ack queue before its ack is sent
Date Tue, 13 Oct 2009 01:09:31 GMT

    [ https://issues.apache.org/jira/browse/HDFS-673?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764905#action_12764905
] 

Hairong Kuang commented on HDFS-673:
------------------------------------

I committed this to trunk and branch 0.21.

I checked branch 0.20. It seems to have the same problem. But strangely I have not seen tests
failed on this in 0.20 branch. Anyboday has seen this bug in 0.20 and wants to commit the
fix to 0.20?

A consequence of this bug is that it introduces false alarms. A good datanode may fail to
send an ack to the client on closedSocket exception when receiving a block.

> BlockReceiver#PacketResponder should not remove a packet from the ack queue before its
ack is sent
> --------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-673
>                 URL: https://issues.apache.org/jira/browse/HDFS-673
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>            Priority: Blocker
>             Fix For: 0.21.0
>
>         Attachments: pkgRmOrder.patch
>
>
> After a BlockReceiver finish receiving the last packet of a block, it waits until the
ack queue becomes empty. It them assumes that all acks have been sent and shunts down network
connections. The current code removes a packet from the ack queue before its ack is sent.
So there is a chance that the connection gets closed before an ack is sent.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message