hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-705) Create an adapter to access some of package-private methods of DataNode from tests
Date Wed, 14 Oct 2009 22:08:31 GMT

    [ https://issues.apache.org/jira/browse/HDFS-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765781#action_12765781
] 

Philip Zeyliger commented on HDFS-705:
--------------------------------------

In other places, I've seen things marked as public with a comment (we could also do annotation)
indicating that it ought to be used for testing only.  If the package is server.datanode,
that's pretty clearly internal to HDFS, no?

I'm merely curious about the preferred coding style for this codebase.  Definitely something
JSR 294 ("superpackages") will help address.

-- Philip

> Create an adapter to access some of package-private methods of DataNode from tests
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-705
>                 URL: https://issues.apache.org/jira/browse/HDFS-705
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.22.0
>
>         Attachments: HDFS-705.patch
>
>
> Some of tests from packages other than {{org.apache.hadoop.hdfs.server.datanode}} need
an access to package-private methods of that package. Proposed patch will add new adapter
class which will have public getter methods to provide such access to outside of the package.
> This is TEST ONLY class: it never has to be used for ANY development purposes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message