hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-719) Add more fault injection tests for pipeline close
Date Wed, 21 Oct 2009 16:41:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768320#action_12768320
] 

Konstantin Boudnik commented on HDFS-719:
-----------------------------------------

Few points:
- instead of
{noformat}
-    private BlockReceiver receiver; // The owner of this responder.
+    final BlockReceiver receiver; // The owner of this responder.
{noformat}
you can declare this aspect to be {{privileged}} - it will have access to the private members
of the class.
- the following method returns {{long}} but the javadoc is about {{int}}
{noformat}
+   * Return a random integer uniformly distributed over the interval [min,max).
    * Assume max - min <= Integer.MAX_VALUE.
    */
   public static long nextRandomLong(final long min, final long max) {
{noformat}

+1 Looks good otherwise

> Add more fault injection tests for pipeline close
> -------------------------------------------------
>
>                 Key: HDFS-719
>                 URL: https://issues.apache.org/jira/browse/HDFS-719
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.21.0, 0.22.0
>
>         Attachments: h719_20091020.patch
>
>
> Implement pipeline fault injection tests to simulate slow datanodes, out of memory problems
and disk errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message