hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-736) commitBlockSynchronization() should directly update block GS and length.
Date Thu, 29 Oct 2009 01:14:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-736?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771238#action_12771238

Hadoop QA commented on HDFS-736:

+1 overall.  Here are the results of testing the latest attachment 
  against trunk revision 830003.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/65/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/65/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/65/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h2.grid.sp2.yahoo.net/65/console

This message is automatically generated.

> commitBlockSynchronization() should directly update block GS and length.
> ------------------------------------------------------------------------
>                 Key: HDFS-736
>                 URL: https://issues.apache.org/jira/browse/HDFS-736
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.21.0
>         Attachments: commitBlockSync.patch
> {{FSNamesystem.commitBlockSynchronization()}} updates block's generation stamp and length
by first removing the old block instance from blocksMap and then inserting the new instance
back. This was necessary when GS was a part of the block key. After HDFS-512 the GS along
with the block length can be updated directly in the blocksMap entry.

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message