hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-632) hdfsJniHelper.c: #include <error.h> is not portable
Date Thu, 29 Oct 2009 17:43:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-632?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12771509#action_12771509
] 

Hadoop QA commented on HDFS-632:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12423597/HDFS-632.patch
  against trunk revision 830804.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: http://hudson.zones.apache.org/hudson/job/Hdfs-Patch-h5.grid.sp2.yahoo.net/89/console

This message is automatically generated.

> hdfsJniHelper.c: #include <error.h> is not portable
> ---------------------------------------------------
>
>                 Key: HDFS-632
>                 URL: https://issues.apache.org/jira/browse/HDFS-632
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Allen Wittenauer
>         Attachments: HDFS-632.patch
>
>
> hdfsJniHelper.c includes <error.h> but this appears to be unnecessary, since even
under Linux none of the routines that are prototyped are used.  Worse yet, error.h doesn't
appear to be a standard header file so this breaks on Mac OS X and Solaris and prevents libhdfs
from being built.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message