hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-680) Add new access method to a copy of a block's replica
Date Tue, 13 Oct 2009 19:50:31 GMT

    [ https://issues.apache.org/jira/browse/HDFS-680?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765201#action_12765201
] 

Konstantin Boudnik commented on HDFS-680:
-----------------------------------------

As we have discussed off-line having a true Replica's clone might help to avoid copy-constructor
implementations for all sub-classes. Although, cloning doesn't work very well in this case
as in 'ugly'.

Patch looks fine. 

Nits:
- line 92:93 seems like a white-space mod
- line 83:84 has changed the formatting

+1 other than that!

> Add new access method to a copy of a block's replica
> ----------------------------------------------------
>
>                 Key: HDFS-680
>                 URL: https://issues.apache.org/jira/browse/HDFS-680
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Shvachko
>             Fix For: 0.21.0
>
>         Attachments: replicaClone.patch
>
>
> Sometimes tests (and perhaps other client applications) might need an access to the state
of a block's replica.
> Currently it is accessible through  {{FSDataset}} member of {{DataNode}} class. However,
{{FSDataset}} is an internal matter of {{DataNode}} and shouldn't be available externally.
> This JIRA will provide new getter method which will be returning a copy of a block's
replica instead of a reference to an actual replica. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message