hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-719) Add more fault injection tests for pipeline close
Date Wed, 21 Oct 2009 18:53:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12768371#action_12768371
] 

Tsz Wo (Nicholas), SZE commented on HDFS-719:
---------------------------------------------

{noformat}
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 15 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of
release audit warnings.
{noformat}
The new tests were passed in my local machine.

In the previous Hudson run, it passed all the aop tests.  The failure of TestFileAppend2.testComplexAppend
 is not related to this.  There was no contrib test failing.  I also checked the raw log but
don't know why getting a -1 on contrib tests.

In the new patch, all changes are localized to aop.  So it won't affect contrib and other
non-aop components.  It is safe to commit it.

> Add more fault injection tests for pipeline close
> -------------------------------------------------
>
>                 Key: HDFS-719
>                 URL: https://issues.apache.org/jira/browse/HDFS-719
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: 0.21.0, 0.22.0
>
>         Attachments: h719_20091020.patch, h719_20091021.patch
>
>
> Implement pipeline fault injection tests to simulate slow datanodes, out of memory problems
and disk errors.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message