hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HDFS-705) Create an adapter to access some of package-private methods of DataNode from tests
Date Thu, 15 Oct 2009 01:35:31 GMT

     [ https://issues.apache.org/jira/browse/HDFS-705?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Konstantin Boudnik updated HDFS-705:
------------------------------------

    Attachment: HDFS-705.patch

I agree with Konstantin's point: we need to move test related methods to an adapters like
this one wherever possible. Your comments are addressed (I have no idea why I was dissecting
this poor thing instead of calling {{getSimplename()}} - don't ask :-)

On the second thought (thanks Nicholas) i decided to get rid of the assertion because it will
add hardcoded limitation and might affect tests which are coming from differently named classes.
Although the chances are slim. 

Thus, simplified version of the patch, but essentially the same.

> Create an adapter to access some of package-private methods of DataNode from tests
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-705
>                 URL: https://issues.apache.org/jira/browse/HDFS-705
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.22.0
>
>         Attachments: HDFS-705.patch, HDFS-705.patch, HDFS-705.patch
>
>
> Some of tests from packages other than {{org.apache.hadoop.hdfs.server.datanode}} need
an access to package-private methods of that package. Proposed patch will add new adapter
class which will have public getter methods to provide such access to outside of the package.
> This is TEST ONLY class: it never has to be used for ANY development purposes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message