hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-677) Rename failure due to quota results in deletion of src directory
Date Sat, 10 Oct 2009 00:52:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-677?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12764273#action_12764273
] 

Konstantin Shvachko commented on HDFS-677:
------------------------------------------

The patch looks good. I went through the main logic in {{unprotectedRenameTo()}}. Most of
conditions in which rename is inapplicable are checked in advance before moving anything anywhere.
Everything seems correct. But it will need extensive testing. To make sure all the math is
right in {{verifyQuota()}}, etc.
Small things:
- Check the value returned by getExistingPathINodes(), compare it with the number of path
components.
- verifyQuota() needs JavaDoc - don't want to read code every time I need to know what it
does.
- you addChild() with {{inheritPermission == true}}. In the old code it was {{false}}. Is
that intentional?


> Rename failure due to quota results in deletion of src directory
> ----------------------------------------------------------------
>
>                 Key: HDFS-677
>                 URL: https://issues.apache.org/jira/browse/HDFS-677
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.20.1, 0.20.2, 0.21.0, 0.22.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>            Priority: Blocker
>             Fix For: 0.20.2, 0.21.0, 0.22.0
>
>         Attachments: hdfs-677.8.patch
>
>
> Renaming src to destination where src has exceeded the quota to a dst without sufficent
quota fails. During this failure, src is deleted. 

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message