hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Philip Zeyliger (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-705) Create an adapter to access some of package-private methods of DataNode from tests
Date Thu, 15 Oct 2009 00:03:31 GMT

    [ https://issues.apache.org/jira/browse/HDFS-705?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765822#action_12765822
] 

Philip Zeyliger commented on HDFS-705:
--------------------------------------

bq. In fact, I thought that it might be pretty cool idea to assert on invocation class' name
if it doesn't start with Test... 

It's cute, but it seems unnecessary.  If people are loading classes from foo-test.jar, they
deserve everything that goes wrong.

In a previous life, I simply stuck a VisibleForTesting annotation on things (http://code.google.com/p/google-collections/source/browse/trunk/src/com/google/common/annotations/VisibleForTesting.java?spec=svn80&r=80)
and marked the method I needed public.

> Create an adapter to access some of package-private methods of DataNode from tests
> ----------------------------------------------------------------------------------
>
>                 Key: HDFS-705
>                 URL: https://issues.apache.org/jira/browse/HDFS-705
>             Project: Hadoop HDFS
>          Issue Type: Test
>          Components: test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>             Fix For: 0.22.0
>
>         Attachments: HDFS-705.patch, HDFS-705.patch
>
>
> Some of tests from packages other than {{org.apache.hadoop.hdfs.server.datanode}} need
an access to package-private methods of that package. Proposed patch will add new adapter
class which will have public getter methods to provide such access to outside of the package.
> This is TEST ONLY class: it never has to be used for ANY development purposes.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message