hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-235) Add support for byte-ranges to hftp
Date Fri, 04 Sep 2009 20:28:57 GMT

    [ https://issues.apache.org/jira/browse/HDFS-235?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12751602#action_12751602
] 

Jakob Homan commented on HDFS-235:
----------------------------------

Review patch:

* Class URLOpener may be better as a nested class within ByteRangeInputStream and needs JavaDoc
* ByteRangeInputStream::seekToNewSource still has an unresolved question as to return value.
I would recommend throwing NotSupportedException since the behavior is non-deterministic and
unreliable.
* Does HftpFileSystem::getNameNode(File)URL need to be public? It's better to make them package
private until we have a need to support them as part of the API.
* Rather than casting the URISyntaxException in getNameNodeURL, you can wrap it an IOException
* There is quite a bit of commented out code in open. This needs to be removed.
* TestStreamFile::StrToRanges should start with a lower case s


> Add support for byte-ranges to hftp
> -----------------------------------
>
>                 Key: HDFS-235
>                 URL: https://issues.apache.org/jira/browse/HDFS-235
>             Project: Hadoop HDFS
>          Issue Type: New Feature
>    Affects Versions: 0.21.0
>            Reporter: Venkatesh S
>            Assignee: Bill Zeller
>             Fix For: 0.21.0
>
>         Attachments: hdfs-235-1.patch, hdfs-235-2.patch
>
>
> Support should be similar to http byte-serving.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message