hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-570) When opening a file for read, make the file length avaliable to client.
Date Wed, 02 Sep 2009 01:08:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750219#action_12750219

Konstantin Shvachko commented on HDFS-570:

1. I see a lot of changes that are pure refactoring: like adding "final" to class members
and variables, or removing "public", or reshuffling imports. I am not against your changes,
it is just that they make merging the branch with trunk even more difficult, and obscure the
nature of the new functionality.

2. JavaDoc for {{getReplicaVisibleLength()}} is confusing. Could you please also make it 3
lines rather than 1.

3. Does not need any of the changes.

4. Here you do multiple field and method renames, combined with reformatting. I am lost.

5. Why do you need to abstract getReplicaInfo()? It does not seem that SimulatedFSDataset
actually need it anywhere, at least not yet.

6. You factored out a part of the code into a new method. I cannot see what the new changes

7. Please do not re-sort the imports

8. It is not necessary to remove public from method declaration and remove unused method.

9. No need to remove the private constructor.

Could you please revise your patch so that it only makes the essential changes.
If you want to refactor please do it in a separate patch applied to trunk.

> When opening a file for read, make the file length avaliable to client.
> -----------------------------------------------------------------------
>                 Key: HDFS-570
>                 URL: https://issues.apache.org/jira/browse/HDFS-570
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs client
>    Affects Versions: Append Branch
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: Append Branch
>         Attachments: h570_20090828.patch
> In order to support read consistency, DFSClient needs the file length at the file opening
time.  In the current implmentation, DFSClient obtains the file length at the file opening
time but the length is inaccurate if the file is being written.
> For more details, see Section 4 in the [append design doc|https://issues.apache.org/jira/secure/attachment/12415768/appendDesign2.pdf].

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message