hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-631) Changes in HDFS to rename the config keys as detailed in HDFS-531.
Date Wed, 30 Sep 2009 20:08:23 GMT

    [ https://issues.apache.org/jira/browse/HDFS-631?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760989#action_12760989
] 

Jakob Homan commented on HDFS-631:
----------------------------------

Reviewed patch.
* In hdfs-default.xml, tying the config version number to the release number is probably not
a good idea, since it apparently will change with each new config value (per Jitendra). Something
more along the way we version protocol numbers, starting at 0 and incrementing for each change
may be better.
* In DFSClient.java:572 the default value of 512 should probably be specified in the defaults
file rather than defined on that line.
* There are quite a few places where constant strings are not being used. Per Jitendra these
haven't been converted in order to keep the patch size reasonable, which sounds good.  However,
a new jira should be opened to convert all naked strings to constant values.
* There is a change not directly related to this patch: deleting the access token keys and
moving them to common. This should be noted.
* There are about ten classes where constant strings are mixed with regular string values
that should be looked at, following the merge of this patch on the append branch: Test{NameNodeMetrics,
SetTimes, NameNodeMetricsInGetListingOps, RenameWhileOpen, AccessTokenWithDFS, DataNodeBlockScanner,
Replication, Delete, FileCreation, DataNodeDeath}.

> Changes in HDFS to rename the config keys as detailed in HDFS-531.
> ------------------------------------------------------------------
>
>                 Key: HDFS-631
>                 URL: https://issues.apache.org/jira/browse/HDFS-631
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Jitendra Nath Pandey
>            Assignee: Jitendra Nath Pandey
>             Fix For: 0.21.0
>
>         Attachments: HDFS-631.1.patch, HDFS-631.21-append.1.patch, HDFS-631.trunk.2.patch,
HDFS-631.trunk.4.patch, HDFS-631.trunk.5.patch
>
>
> This jira tracks the code changes required in HDFS to rename the config keys. The list
of changed keys is attached to HDFS-531.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message