hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-570) When opening a file for read, make the file length avaliable to client.
Date Wed, 02 Sep 2009 18:32:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-570?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12750596#action_12750596

Tsz Wo (Nicholas), SZE commented on HDFS-570:

2. JavaDoc for getReplicaVisibleLength() is confusing. Could you please also make it 3 lines
rather than 1.
Why 3 lines?

3. Does not need any of the changes.
Could you explain more?

4. Here you do multiple field and method renames, combined with reformatting. I am lost.
How can I help you?

5. Why do you need to abstract getReplicaInfo()? It does not seem that SimulatedFSDataset
actually need it anywhere, at least not yet.
FSDatasetInterface is an *interface*.  By definition, all methods in an interface must be

6. You factored out a part of the code into a new method. I cannot see what the new changes
The new method is involved in FSNamesystem.  Could you take a look again?

8. It is not necessary to remove public from method declaration and remove unused method.
I remove the method because I see the following comment in the code.
// SHV !!! this is not used anywhere - remove
The comment was introduced by you in HDFS-517.  Could you explain what does it mean?

> When opening a file for read, make the file length avaliable to client.
> -----------------------------------------------------------------------
>                 Key: HDFS-570
>                 URL: https://issues.apache.org/jira/browse/HDFS-570
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: hdfs client
>    Affects Versions: Append Branch
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>             Fix For: Append Branch
>         Attachments: h570_20090828.patch
> In order to support read consistency, DFSClient needs the file length at the file opening
time.  In the current implmentation, DFSClient obtains the file length at the file opening
time but the length is inaccurate if the file is being written.
> For more details, see Section 4 in the [append design doc|https://issues.apache.org/jira/secure/attachment/12415768/appendDesign2.pdf].

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message