hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-608) BlockReceiver:receivePacket(): packet's header parsing logic is complicated. Refactoring will help w/ testing efforts
Date Thu, 10 Sep 2009 01:13:57 GMT

    [ https://issues.apache.org/jira/browse/HDFS-608?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12753357#action_12753357
] 

Konstantin Boudnik commented on HDFS-608:
-----------------------------------------

After conversing with Konstantin and Raghu I've been convinced that the fix has to be applied
on both sides - i.e. BlockReceiver and DFSClient - at the same time.

Because the effort is likely to require quite a bit of testing efforts it seems to be impractical
to undertake in before 0.21 (and append) are completed. Thus, it's going to be postponed until
after 0.21 time frame.

> BlockReceiver:receivePacket(): packet's header parsing logic is complicated. Refactoring
will help w/ testing efforts
> ---------------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-608
>                 URL: https://issues.apache.org/jira/browse/HDFS-608
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-608.patch
>
>
> Current logic of getting an information from a packet header is kinda complicated with
all shifting along the internal data buffer back and forth. 
> Besides, an absence of clear API to access a packet header's information makes pipeline
testing effort (even with aspects' application) to be a very complicated or even impossible.

> It'd be very nice to have a separate data container which will keep all the information
about a packet header within and will initialized once when a new packet is acquired. 
> In order to speed-up pipeline testing needed for append (HDFS-265) this modification
might implemented in three different states:
> - introduce new header structure and refactor receivePacket()
> - refactor readNextPacket so it it will acquire next packet in initialize its header
> - refactor the sender side to use the packet's header structure as the receiver does.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message