hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-589) Change block write protocol to support pipeline recovery
Date Sat, 12 Sep 2009 01:20:57 GMT

    [ https://issues.apache.org/jira/browse/HDFS-589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12754457#action_12754457
] 

Tsz Wo (Nicholas), SZE commented on HDFS-589:
---------------------------------------------

- I think it is better to change
{code}
+    public static BlockConstructionStage valueOf(
+        byte code, boolean isRecovery) {
+      return valueOf((byte)(isRecovery ? (code|RECOVERY_BIT) : code));
+    }
{code}
to
{code}
    public BlockConstructionStage combine(boolean isRecovery) {
      return isRecovery? valueOf(ordinal()|RECOVERY_BIT): this;
    }
{code}
Then, the codes in DFSClient becomes
{code}
          BlockConstructionStage blockStage = stage.combine(recoveryFlag);
{code}

- In line 737 of the patch,
{code}
+                // stage = BlockConstructionStage.PIPELINE_CLOSE;
{code}
Should it be un-commented?

> Change block write protocol to support pipeline recovery
> --------------------------------------------------------
>
>                 Key: HDFS-589
>                 URL: https://issues.apache.org/jira/browse/HDFS-589
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: Append Branch
>            Reporter: Hairong Kuang
>            Assignee: Hairong Kuang
>             Fix For: Append Branch
>
>         Attachments: opWriteProtocol.patch
>
>
> Current block write operation's header has the following fields:
> blockId blockGS pipelineSize isRecovery clientName hasSource source #datanodesInDownStreamPipeline
downstreamDatanodes
> I'd like to change the header to be
> blockId blockGS pipelineSize clientName  flags blockMinLen blockMaxLen newGS hasSource
source #datanodesInDownStreamPipeline downstreamDatanodes
> With this protocol change, pipeline recovery will be performed when a mew pipeline is
set up.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message