hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-616) Create functional tests for new design of the block report
Date Tue, 29 Sep 2009 00:45:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12760457#action_12760457

Konstantin Shvachko commented on HDFS-616:

# iterBlkLocs() is not used anywhere.
# BlockReport_04() corrupts the data in the block. This is more testing of the block scanner
than block report, because blockReport() does not verify crcs. So may be we should drop this
test case.
# In BlockReport_07() you corrupt GS of secondDNblock, but you still report the old list of
blocks with the old GS, so the NN does not get the message the block is corrupt.
# It would be better to name methods blockReport_**() - no capitalization for the first word.

Other than that this is a good set of tests.

> Create functional tests for new design of the block report
> ----------------------------------------------------------
>                 Key: HDFS-616
>                 URL: https://issues.apache.org/jira/browse/HDFS-616
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: test
>    Affects Versions: Append Branch
>            Reporter: Konstantin Boudnik
>            Assignee: Konstantin Boudnik
>         Attachments: HDFS-616.patch, HDFS-616.patch, HDFS-616.patch

This message is automatically generated by JIRA.
You can reply to this email to add a comment to the issue online.

View raw message