hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-506) Incorrect UserName at Solaris because it has no "whoami" command by default
Date Fri, 18 Sep 2009 21:32:16 GMT

    [ https://issues.apache.org/jira/browse/HDFS-506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12757454#action_12757454
] 

Todd Lipcon commented on HDFS-506:
----------------------------------

bq. Because we have to maintain such OS specific codes forever. Once the codes have got in,
it is hardly to remove them because removing them becomes an incompatible change.

I agree with this sentiment about maintenance, but I don't see how this would be an incompatible
change. The existence of a whoami executable is not something that's part of the API - the
user assumes that most software will "just work". Calling out to "whoami" is a hack in the
first place, and hopefully will be removed soon when true authentication support makes it
into Hadoop.

+1 for fixing this, though I don't think the patch is so great. Can you format this as a proper
single-file patch against the hadoop-common repository? I'll move this to the HADOOP JIRA
since this is not HDFS-specific. See http://wiki.apache.org/hadoop/HowToContribute for information
on how to format a patch to be committed.

> Incorrect UserName at Solaris because it has no "whoami" command by default
> ---------------------------------------------------------------------------
>
>                 Key: HDFS-506
>                 URL: https://issues.apache.org/jira/browse/HDFS-506
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: documentation
>    Affects Versions: 0.20.1
>         Environment: OS: SunOS 5.10
>            Reporter: Urko Benito
>         Attachments: PermissionChecker.java.diff, Shell.java.diff, test-hadoop-security.tar.gz,
UnixUserGroupInformation.java.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Solaris enviroment has no __whoami__ command, so the __getUnixUserName()__ at UnixUserGroupInformation
class fails because it's calling to Shell.USER_NAME_COMMAND which is defines as "whoami".
> So it launched an Exception and set the default "DrWho" username ignoring all the FileSystem
permissions.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message