Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 33854 invoked from network); 26 Aug 2009 21:50:22 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 26 Aug 2009 21:50:22 -0000 Received: (qmail 52224 invoked by uid 500); 26 Aug 2009 21:50:21 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 52170 invoked by uid 500); 26 Aug 2009 21:50:21 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 52151 invoked by uid 99); 26 Aug 2009 21:50:21 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2009 21:50:21 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 26 Aug 2009 21:50:19 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id 8600F234C48D for ; Wed, 26 Aug 2009 14:49:59 -0700 (PDT) Message-ID: <78331444.1251323399548.JavaMail.jira@brutus> Date: Wed, 26 Aug 2009 14:49:59 -0700 (PDT) From: "Suresh Srinivas (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-543) Break FSDatasetInterface#writeToBlock() into writeToTemporary, writeToRBW, and append In-Reply-To: <106594285.1250101994967.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-543?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748170#action_12748170 ] Suresh Srinivas commented on HDFS-543: -------------------------------------- +1 for the patch > Break FSDatasetInterface#writeToBlock() into writeToTemporary, writeToRBW, and append > ------------------------------------------------------------------------------------- > > Key: HDFS-543 > URL: https://issues.apache.org/jira/browse/HDFS-543 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: data-node > Affects Versions: Append Branch > Reporter: Hairong Kuang > Assignee: Hairong Kuang > Fix For: Append Branch > > Attachments: writeToReplica.patch, writeToReplica1.patch, writeToReplica2.patch, writeToReplica3.patch > > > FSDatasetInterface#writeToBlock() currently allows to create/recover a temporary replica, create/recover a RBW replica, or append to a replica. The implementation of the method in FSDataset is very complicated and error prone. I'd like to break this method into 3: > 1. writeToTemporary allows to create a Temporary replica or recover from a packet error for a Tempoary replica; > 2. writeToRBW allows to create a RBW replica or recover from a packet error for a RBW replica; > 3. append allows to append to an existing Finalized replica. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.