Return-Path: Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: (qmail 2718 invoked from network); 27 Aug 2009 07:07:23 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 27 Aug 2009 07:07:23 -0000 Received: (qmail 94754 invoked by uid 500); 27 Aug 2009 07:07:23 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 94657 invoked by uid 500); 27 Aug 2009 07:07:23 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 94638 invoked by uid 99); 27 Aug 2009 07:07:23 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Aug 2009 07:07:23 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=10.0 tests=ALL_TRUSTED X-Spam-Check-By: apache.org Received: from [140.211.11.140] (HELO brutus.apache.org) (140.211.11.140) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Aug 2009 07:07:20 +0000 Received: from brutus (localhost [127.0.0.1]) by brutus.apache.org (Postfix) with ESMTP id B376D234C053 for ; Thu, 27 Aug 2009 00:06:59 -0700 (PDT) Message-ID: <2069836362.1251356819734.JavaMail.jira@brutus> Date: Thu, 27 Aug 2009 00:06:59 -0700 (PDT) From: "Suresh Srinivas (JIRA)" To: hdfs-issues@hadoop.apache.org Subject: [jira] Commented: (HDFS-525) ListPathsServlet.java uses static SimpleDateFormat that has threading issues In-Reply-To: <188096223.1249350134826.JavaMail.jira@brutus> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12748283#action_12748283 ] Suresh Srinivas commented on HDFS-525: -------------------------------------- I am not sure what you mean by odd pattern. The advantage clearly is to be able to replace the existing SimpleDateFormat with ThreadLocalDateFormat, without having to add all the code related to making a thread local SimpleDateFormat in every place. > ListPathsServlet.java uses static SimpleDateFormat that has threading issues > ---------------------------------------------------------------------------- > > Key: HDFS-525 > URL: https://issues.apache.org/jira/browse/HDFS-525 > Project: Hadoop HDFS > Issue Type: Bug > Components: name-node > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Fix For: 0.20.1, 0.21.0 > > Attachments: HDFS-525.1.patch, HDFS-525.2.patch, HDFS-525.patch, HDFS-525.patch, HDFS-525.rel20.patch, HDFS.525-3.patch > > > SimpleDateFormat is not thread safe. Multiple threads accessing the servlet can cause threading issues -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.