Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <1990180278.1249669874803.JavaMail.jira@brutus>
Date: Fri, 7 Aug 2009 11:31:14 -0700 (PDT)
From: "Jakob Homan (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-409) Add more access token tests
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-409?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740670#action_12740670 ] 

Jakob Homan commented on HDFS-409:
----------------------------------

Reviewed. 
* restartDataNode(DataNodeProperties dnprop, boolean keepPort) needs javadoc
* I think the changes to MiniDFSCluster::waitActive could be improved by creating two loops, one for dn registration and one for dn heartbeats.  You'd have the same number of RPC calls, but improve the number of times through the loops, as well as making the code easier to understand.

Otherwise looks good.  I really like the heavy documentation in the unit tests.  Looks faithful to the test plan.


> Add more access token tests
> ---------------------------
>
>                 Key: HDFS-409
>                 URL: https://issues.apache.org/jira/browse/HDFS-409
>             Project: Hadoop HDFS
>          Issue Type: Test
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: AccessTokenTestPlan.pdf, h409-23.patch
>
>
> Need to add more unit tests for access token

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.