Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <1736461167.1251226799654.JavaMail.jira@brutus>
Date: Tue, 25 Aug 2009 11:59:59 -0700 (PDT)
From: "Konstantin Shvachko (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-563) Simplify the codes in
 FSNamesystem.getBlockLocations(..)
In-Reply-To: <909975855.1250895014954.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747572#action_12747572 ] 

Konstantin Shvachko commented on HDFS-563:
------------------------------------------

This is a very good idea to expose {{namenode}} functionality for tests via a {{Util}} class rather than keeping public methods in the {{NameNode}} itself. Could you please add a JavaDoc comment saying something like "This is a utility class to expose NameNode functionality for unit tests."
In order to establish the right precedence it would be better to change parameter FSNamesystem to NameNode in Util.getBlockLocations(). That way we will be able to make getNamesystem() method package private down the road.

> Simplify the codes in FSNamesystem.getBlockLocations(..)
> --------------------------------------------------------
>
>                 Key: HDFS-563
>                 URL: https://issues.apache.org/jira/browse/HDFS-563
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>             Fix For: 0.21.0
>
>         Attachments: h563_20090821.patch
>
>
> There are un-used codes in FSNamesystem.getBlockLocations(..).  Also, some codes can be moved to tests.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.