hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-561) Fix write pipeline READ_TIMEOUT
Date Mon, 24 Aug 2009 21:57:59 GMT

    [ https://issues.apache.org/jira/browse/HDFS-561?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12747098#action_12747098
] 

Tsz Wo (Nicholas), SZE commented on HDFS-561:
---------------------------------------------

patch look good except that there are un-used imports in DFSClientAspects.

Some suggestions:
Currently, both ActionContainer.run(..) and Action.run(..) throw IOException.  However, some
implementation like VerificationAction may not throw IOException.  My suggestion is to add
a generic type to Action and ActionContainer as shown below.
{code}
  public static interface Action<T, E extends Exception> {
    /** Run the action with the parameter. */
    public void run(T parameter) throws E;
  }

  /** An ActionContainer contains at most one action. */
  public static class ActionContainer<T, E extends Exception> {
    private Action<T, E> action;

    /** Create an empty container. */
    public ActionContainer() {}

    /** Set action. */
    public void set(Action<T, E> a) {action = a;}

    /** Run the action if it exists. */
    public void run(T obj) throws E {
      if (action != null) {
        action.run(obj);
      }
    }
  }
{code}
We may do this in a separated issue.

> Fix write pipeline READ_TIMEOUT
> -------------------------------
>
>                 Key: HDFS-561
>                 URL: https://issues.apache.org/jira/browse/HDFS-561
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: data-node, hdfs client, test
>            Reporter: Kan Zhang
>            Assignee: Kan Zhang
>         Attachments: h561-01.patch
>
>
> When writing a file, the pipeline status read timeouts for datanodes are not set up properly.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message