hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jakob Homan (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-529) More redundant block searches in BlockManager.
Date Wed, 05 Aug 2009 20:23:15 GMT

    [ https://issues.apache.org/jira/browse/HDFS-529?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12739719#action_12739719
] 

Jakob Homan commented on HDFS-529:
----------------------------------

Looks almost good.  Talked offline about the TODO comment and the poor comment below one of
the methods.

> More redundant block searches in BlockManager.
> ----------------------------------------------
>
>                 Key: HDFS-529
>                 URL: https://issues.apache.org/jira/browse/HDFS-529
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.21.0
>
>         Attachments: BlocksMap.patch
>
>
> Found more redundant searches in {{BlockManager.addStoredBLock()}} and {{BlockManager.getNodes(Block)}}.
> The pattern here is that we first call {{BlocksMap.numNodes(Block)}} in order to determine
the size of the array of data-nodes. This is one search in {{blocksMap}}. Then we call {{BlocksMap.nodeIterator(Block)}},
which also performs a search. This is all not necessary because we already have the block
in the form of BlockInfo from {{blocksMap}} and do not need to search for it.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message