Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <386895436.1246858514804.JavaMail.jira@brutus>
Date: Sun, 5 Jul 2009 22:35:14 -0700 (PDT)
From: "Raghu Angadi (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Commented: (HDFS-456) Problems with dfs.name.edits.dirs as
 URI
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12727396#action_12727396 ] 

Raghu Angadi commented on HDFS-456:
-----------------------------------

Thanks for the fix.

Minor change : 
{noformat}
+          u = new File(name).getCanonicalFile().toURI();
+          LOG.warn("Use of file paths is deprecated for property " 
+              + propertyName);
+          LOG.warn("Please update your configuration");
{noformat}
This prints two separate lines. Could you merge it? We usually have one for for that entire message so that each line is self contained.. makes parsing and grepping easy (stack traces are an exception of course). Also it might be better to suggest users to use URI in the message.


> Problems with dfs.name.edits.dirs as URI
> ----------------------------------------
>
>                 Key: HDFS-456
>                 URL: https://issues.apache.org/jira/browse/HDFS-456
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Luca Telloli
>             Fix For: 0.21.0
>
>         Attachments: HDFS-456.patch
>
>
> There are several problems with recent commit of HDFS-396.
> # It does not work with default configuration "file:///". Throws {{IllegalArgumentException}}.
> # *ALL* hdfs tests fail on Windows because "C:\mypath" is treated as an illegal URI. Backward compatibility is not provided.
> # {{IllegalArgumentException}} should not be thrown within hdfs code because it is a {{RuntimException}}. We should throw {{IOException}} instead. This was recently discussed in another jira.
> # Why do we commit patches without running unit tests and test-patch? This is the minimum requirement for a patch to qualify as committable, right?

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.