Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Message-ID: <160598897.1248989954814.JavaMail.jira@brutus>
Date: Thu, 30 Jul 2009 14:39:14 -0700 (PDT)
From: "Konstantin Shvachko (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Subject: [jira] Updated: (HDFS-511) Redundant block searches in
 BlockManager.
In-Reply-To: <671244695.1248823875169.JavaMail.jira@brutus>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Konstantin Shvachko updated HDFS-511:
-------------------------------------

    Attachment: BlockManager.patch

Don't see any rational reasons to keep the old method in BlockManager, but here it is.
I had to rename it to {{findAndMarkBlockAsCorrupt()}} because if there are two methods with the same name it would be unclear which method is actually called for a stored block.

> Redundant block searches in BlockManager.
> -----------------------------------------
>
>                 Key: HDFS-511
>                 URL: https://issues.apache.org/jira/browse/HDFS-511
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.21.0
>
>         Attachments: BlockManager.patch, BlockManager.patch, BlockManager.patch
>
>
> Some searches for a block in {{blocksMap}} are redundant and should be eliminated.
> {{BlockManager.addStoredBlock()}} contain unnecessary explicit and hidden (inside {{markBlockAsCorrupt()}}) calls of {{blocksMap.getStoredBlock()}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.