hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-501) Use enum to define the constants in DataTransferProtocol
Date Sat, 25 Jul 2009 00:39:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735219#action_12735219
] 

Suresh Srinivas commented on HDFS-501:
--------------------------------------

+1

Nits:
# BlockReceiver.java - Indenting of {{op}} declaration around line 854, is not indented with
the rest of the code (though the existing code does not follow 2 space indentation)
# Use {{read(in)}} method instead {{valueOf(in.readByte()}}. Currently both these methods
are used. Perhaps {{valueOf()}} could be private. This will also be better in case these fields
change from byte to some other type.


> Use enum to define the constants in DataTransferProtocol
> --------------------------------------------------------
>
>                 Key: HDFS-501
>                 URL: https://issues.apache.org/jira/browse/HDFS-501
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node, hdfs client
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h501_20090724.patch
>
>
> There are quite a few integer (int/byte) constants defined in DataTransferProtocol. 
It is better to replace them by enums.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message