hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Updated: (HDFS-511) Redundant block searches in BlockManager.
Date Wed, 29 Jul 2009 19:10:14 GMT

     [ https://issues.apache.org/jira/browse/HDFS-511?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Konstantin Shvachko updated HDFS-511:
-------------------------------------

    Attachment: BlockManager.patch

This fixes one findbug in the previous version of the patch.
The test-patch targets complains there are no new tests, which is correct since this does
not introduce any new behavior.
{code}
[exec] There appear to be 154 release audit warnings before the patch and 154 release audit
warnings after applying the patch.
[exec] -1 overall.  
[exec]     +1 @author.  The patch does not contain any @author tags.
[exec]     -1 tests included.  The patch doesn't appear to include any new or modified tests.
[exec]                         Please justify why no new tests are needed for this patch.
[exec]                         Also please list what manual steps were performed to verify
this patch.
[exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
[exec]     +1 javac.  The applied patch does not increase the total number of javac compiler
warnings.
[exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
[exec]     +1 release audit.  The applied patch does not increase the total number of release
audit warnings.
[exec] ======================================================================
[exec] ======================================================================
[exec]     Finished build.
[exec] ======================================================================
[exec] ======================================================================
{code}

> Redundant block searches in BlockManager.
> -----------------------------------------
>
>                 Key: HDFS-511
>                 URL: https://issues.apache.org/jira/browse/HDFS-511
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.21.0
>            Reporter: Konstantin Shvachko
>            Assignee: Konstantin Shvachko
>             Fix For: 0.21.0
>
>         Attachments: BlockManager.patch, BlockManager.patch
>
>
> Some searches for a block in {{blocksMap}} are redundant and should be eliminated.
> {{BlockManager.addStoredBlock()}} contain unnecessary explicit and hidden (inside {{markBlockAsCorrupt()}})
calls of {{blocksMap.getStoredBlock()}}.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message