hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Shvachko (JIRA)" <j...@apache.org>
Subject [jira] Commented: (HDFS-504) HDFS updates the modification time of a file when the file is closed.
Date Mon, 27 Jul 2009 17:52:14 GMT

    [ https://issues.apache.org/jira/browse/HDFS-504?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12735683#action_12735683
] 

Konstantin Shvachko commented on HDFS-504:
------------------------------------------

To second Dhruba:
# Need to remove empty line changes.
# Still see tabs or wrong indentation, say around sleep statements.
# Please avoid using sleeps in unit tests. This has been discussed previously. It is better
to verify the condition you are waiting for than sleep hoping it will be satisfied when you
wake up. This can not be uniformly tuned for all machines and environments and usually leads
to non-deterministic  test failures.
# {{private byte[] fileContents}} should be a local variable of {{testTimesAtClose()}}.
# Also you use currently unsupported functionality in your test turned on by setting "dfs.support.append"
to true. Unsupported means that it may fail, and this has nothing to do with the modTime.
Same as Dhruba I think the test should be more focused on the introduced functionality.


> HDFS updates the modification time of a file when the file is closed.
> ---------------------------------------------------------------------
>
>                 Key: HDFS-504
>                 URL: https://issues.apache.org/jira/browse/HDFS-504
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.20.1
>            Reporter: Chun Zhang
>            Assignee: Chun Zhang
>            Priority: Minor
>             Fix For: 0.20.1
>
>         Attachments: pathfile.txt, pathfile.txt
>
>   Original Estimate: 2h
>  Remaining Estimate: 2h
>
> Current HDFS updates the modification time of a file when the file is created. We would
like to update the modification time of the file when the file is closed after being written
to. This helps HDFS Raid to detect file changes more aggressively.
> Solution includes:
> 1. Made changes to closeFile@/org/apache/hadoop/hdfs/server/namenode/FSDirectory.java;
> 2. Added unit test to testTimesAtClose@/org/apache/hadoop/hdfs/TestSetTimes.java.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Mime
View raw message